Fix reference counting on python strings

man-group · Nov 13, 2024 · c8cc666 · c8cc666
1 parent b0dad96
commit c8cc666
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/cpp/arcticdb/python/python_strings.hpp b/cpp/arcticdb/python/python_strings.hpp
@@ -177,7 +177,7 @@ class DynamicStringReducer  {
                     }
 
                     allocated.try_emplace(offset, obj);
-                    for (auto c = 0U; c < count; ++c)
+                    for (auto c = 1U; c < count; ++c)
                         inc_ref(obj);
                 }
             }
@@ -202,7 +202,7 @@ class DynamicStringReducer  {
             for (const auto &[offset, count] : unique_counts) {
                 const auto sv = get_string_from_pool(offset, string_pool);
                 auto obj = StringCreator::create(sv, has_type_conversion);
-                for (auto c = 0U; c < count; ++c)
+                for (auto c = 1U; c < count; ++c)
                     inc_ref(obj);
 
                 py_strings.insert(std::make_pair(offset, obj));