Add Montreal service #1654
Merged
Add Montreal service #1654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution. I did some major refactoring to remove your large function with very deep indentation. feel free to have a look. I checked the test output and it did not change. I added the new dependency to the manifest.json as well to communicate the dependency to home-assistant |
Closed
7 tasks
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, Montreal does not offer an iCal/Webcal subscription method.
The GeoJSON file provides sector-specific details.
The waste collection schedule is then interpreted from English natural language. Not every sector follows the same structure.
This method is not highly reliable but serves as an acceptable workaround until a better solution is provided by the city.