Skip to content

Conversation

@holub
Copy link
Contributor

@holub holub commented Jan 30, 2026

After this, for device which implements device_state_interface we can access state from global symtable.
CPU (exec) devices continue to publish their state to separate CPU symtables (child of GLOBAL).

Also suggesting to rename machine().debugger().cpu() to machine().debugger().state() as "cpu" confusing term in this context as far as we can have multiple cpu. <<< will do separately, if requested

@holub
Copy link
Contributor Author

holub commented Feb 3, 2026

I'd like those to be delivered/moved forward: #14908 #14898 #14765 #14754 #14740 #14739 #14328 #13122
Who can I blackmail for this?

@galibert
Copy link
Member

galibert commented Feb 5, 2026

I don't have a problem with renaming state() to cpu(), but I do have a problem with not renaming debugger_cpu to debugger_state then. And the filename too.

@holub
Copy link
Contributor Author

holub commented Feb 5, 2026

Yeah, I was waiting for feedback on this change.
So... revert the field or rename the class as well?

@holub
Copy link
Contributor Author

holub commented Feb 6, 2026

I made an executive decision and only kept functional changes in this PR.
If anybody support "rename", I can bring it as a separate change.

@galibert
Copy link
Member

galibert commented Feb 6, 2026

For other things I want to do I'm going to end up massively reorganizing that crap, so tabling the rename is a good thing

@galibert galibert merged commit 6e0405e into mamedev:master Feb 6, 2026
6 checks passed
@holub holub deleted the sym-state branch February 6, 2026 14:47
@cuavas
Copy link
Member

cuavas commented Feb 7, 2026

So what happens when two devices in a system have a state item with the same name?

@holub
Copy link
Contributor Author

holub commented Feb 7, 2026

This is unpleasant situation where last registered win. But we are far away from this situation as the device needs to be "state" and not be executable. I believe now number of devices which match this condition are close to 0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants