Skip to content

innotv_innotabmax.cpp: Add note about undumped system#14750

Open
vtarchive wants to merge 5 commits intomamedev:masterfrom
vtarchive:patch-21
Open

innotv_innotabmax.cpp: Add note about undumped system#14750
vtarchive wants to merge 5 commits intomamedev:masterfrom
vtarchive:patch-21

Conversation

@vtarchive
Copy link
Contributor

InnoTab Max has backwards compatiblity with most InnoTab titles
https://www.innotabsoftware.com/

Copy link
Contributor Author

@vtarchive vtarchive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i did manage to add the dutch undumped version

@vtarchive
Copy link
Contributor Author

why is this failing?

Copy link
Contributor Author

@vtarchive vtarchive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, and mr men on mobigo is lost media

@angelosa
Copy link
Member

angelosa commented Jan 1, 2026

Because you are changing the romset ID without changing the correlated ROM_START and actually reflecting the change in mame.lst file

@angelosa
Copy link
Member

angelosa commented Jan 1, 2026

Also, you should test whatever you change, locally. I suspect you are not doing that ...

Copy link
Contributor Author

@vtarchive vtarchive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did fix the error

@happppp
Copy link
Member

happppp commented Jan 1, 2026

It still won't compile correctly, because mame.lst wasn't updated.
IMO the romset rename is unnecessary, we normally only add region postfix to the romset name when we have 2 or more regions. eg. setname and setnamej (Japan).

@vtarchive
Copy link
Contributor Author

it works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants