LDP1450: Added preliminary support for custom On Screen Text mode.#13490
Merged
angelosa merged 7 commits intomamedev:masterfrom Jun 18, 2025
Merged
LDP1450: Added preliminary support for custom On Screen Text mode.#13490angelosa merged 7 commits intomamedev:masterfrom
angelosa merged 7 commits intomamedev:masterfrom
Conversation
…ecking against hardware). New working system ------------------ Vision Quest [James Wallace, Jeff Anderson, Dragon's Lair Project]
Member
Author
|
Given the size of the CHD here, I've given access to Tafoid if its needed for review. Any feedback on the OSD functions here is greatly appreciated. |
angelosa
reviewed
Apr 4, 2025
angelosa
reviewed
Apr 4, 2025
angelosa
reviewed
Apr 4, 2025
angelosa
reviewed
Apr 4, 2025
angelosa
reviewed
Apr 4, 2025
Member
Author
|
Putting this in draft until I can fix the validate issues brought about with the latest changes |
angelosa
approved these changes
Jun 10, 2025
Member
angelosa
left a comment
angelosa
left a comment
There was a problem hiding this comment.
The intention is to merge as-is in a couple days to do evaluations later.
cuavas
reviewed
Jun 30, 2025
Comment on lines
+299
to
+323
| u8 modeval= (m_user_index_mode >> 5) & 0x04; | ||
|
|
||
| for (u32 y = 0; y < char_height; y++) | ||
| { | ||
| for (u8 x = 0; x < char_width; x++) | ||
| { | ||
| u32 xmin = xstart + x; | ||
| for (u32 yy = 0; yy < OVERLAY_PIXEL_HEIGHT; yy++) | ||
| { | ||
|
|
||
| for (u32 xx = 0; xx < OVERLAY_PIXEL_WIDTH; xx++) | ||
| { | ||
| if (modeval==0x03) | ||
| { | ||
| //fill with grey | ||
| } | ||
|
|
||
| if (m_osd_font[ch].pix(y,x) != black) | ||
| { | ||
| bitmap.pix(ystart + (y + 1) * OVERLAY_PIXEL_HEIGHT + yy, xmin+xx) = m_osd_font[ch].pix(y,x); | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
It’s impossible for the modeval == 0x03 test to pass, because you assigned it something & 0x04 above, and 0x04 & 0x03 == 0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New working system
Vision Quest [James Wallace, Jeff Anderson, Dragon's Lair Project]