Skip to content

psx.xml: Added 12 working items + 4 redumped items#13347

Merged
rb6502 merged 3 commits intomamedev:masterfrom
ArcadeShadow:psx_2025-02
Feb 15, 2025
Merged

psx.xml: Added 12 working items + 4 redumped items#13347
rb6502 merged 3 commits intomamedev:masterfrom
ArcadeShadow:psx_2025-02

Conversation

@ArcadeShadow
Copy link
Contributor

New working software list additions

16 Tales 1 (USA) [Redump]
2Xtreme (Europe) [Redump]
3Xtreme (USA, demo) [Redump]
3D Lemmings (Europe) [Redump]
3D Lemmings (Japan) [Redump]
4-4-2 Soccer (Europe) [Redump]
40 Winks (Europe) [Redump]
40 Winks (Europe, demo) [Redump]
40 Winks (Italy) [Redump]
40 Winks (Spain) [Redump]
Cheesy (Europe) [Redump]
Cheesy (Japan) [Redump]

Redumped software list items

2Xtreme (USA) [Redump]
3Xtreme (USA) [Redump]
3D Lemmings (USA) [Redump]
40 Winks (USA) [Redump]

New working software list additions
--------------------------------------------
16 Tales 1 (USA) [Redump]
2Xtreme (Europe) [Redump]
3Xtreme (USA, demo) [Redump]
3D Lemmings (Europe) [Redump]
3D Lemmings (Japan) [Redump]
4-4-2 Soccer (Europe) [Redump]
40 Winks (Europe) [Redump]
40 Winks (Europe, demo) [Redump]
40 Winks (Italy) [Redump]
40 Winks (Spain) [Redump]
Cheesy (Europe) [Redump]
Cheesy (Japan) [Redump]

Redumped software list items
--------------------------------------------
2Xtreme (USA) [Redump]
3Xtreme (USA) [Redump]
3D Lemmings (USA) [Redump]
40 Winks (USA) [Redump]
Comment on lines 264 to 268
<!--
http://redump.org/disc/2094/
<rom name="2Xtreme (USA).cue" size="700" crc="7e95393e" sha1="ed526fe2905f428530cc001038dd72c413bbe291"/>
<rom name="2Xtreme (USA) (Track 1).bin" size="45715824" crc="aad124a6" sha1="3f25e5d1366e60e70a416109711e109d48c9f19b"/>
<rom name="2Xtreme (USA) (Track 2).bin" size="56064624" crc="6f8d371b" sha1="9b986d87e8314c72757f629f6d7201bdeb0190b0"/>
Copy link
Member

@angelosa angelosa Feb 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's open a discussion about this:
as part of their clearance http://redump.org/ gives this information already in the given URL. I legit don't think parsing XML comments as a pseudo-field is trivial, plus the verbosity of these track lines that don't even report back the msf to begin with, so it needs a roundtrip to the website anyway.
What if we just use something like <info name="redump.org" value="2094" />, where of course 2094 is the ID that needs parsing thru clients including MAME UI itself?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's fair enough for me.
All the hash information is irrelevant, with the source and ID indicated.

@etabeta78
Copy link
Contributor

etabeta78 commented Feb 9, 2025 via email

hash/psx.xml Outdated
Comment on lines 389 to 393
<notes>Compatibility set as PAL since it didn't work on NTSC system</notes>
<info name="developer" value="989 Sports" />
<info name="language" value="English" />
<info name="serial" value="SCUS-94231"/>
<sharedfeat name="compatibility" value="PAL-E"/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't really make sense. At worst you should just drop the sharedfeat instead, it clearly sounds as something that needs investigating (and inclined to supported="no" here).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed flag to supported="no" and change to compatibility to NTSC-U

@angelosa
Copy link
Member

As such I think the site ID is enough, but I think it is mostly appropriate
as a comment field

I think it's appropriate in the need of not looking at a XML file for something that a frontend can optionally parse and/or allow user to click on it. That's valid for good external source of truth as well, not necessarily redump.org alone.

@etabeta78
Copy link
Contributor

etabeta78 commented Feb 12, 2025 via email

Set "3Xtreme (USA)" as not supported
Bulk replace "psx_cdrom" interface to "cdrom"
@angelosa angelosa self-requested a review February 12, 2025 22:59
@rb6502 rb6502 merged commit 95eb534 into mamedev:master Feb 15, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants