heathzenith/h89.cpp: Convert SigmaSoft parallel port into an h89 left card. #13024
Conversation
| ctrl_r_cb().set(":tlbc", FUNC(heath_tlb_connector::sigma_ctrl_r)); | ||
| video_mem_r_cb().set(":tlbc", FUNC(heath_tlb_connector::sigma_video_mem_r)); | ||
| video_mem_cb().set(":tlbc", FUNC(heath_tlb_connector::sigma_video_mem_w)); | ||
| io_lo_cb().set(":tlbc", FUNC(heath_tlb_connector::sigma_io_lo_addr_w)); | ||
| io_hi_cb().set(":tlbc", FUNC(heath_tlb_connector::sigma_io_hi_addr_w)); | ||
| window_lo_cb().set(":tlbc", FUNC(heath_tlb_connector::sigma_window_lo_addr_w)); | ||
| window_hi_cb().set(":tlbc", FUNC(heath_tlb_connector::sigma_window_hi_addr_w)); | ||
| ctrl_cb().set(":tlbc", FUNC(heath_tlb_connector::sigma_ctrl_w)); |
There was a problem hiding this comment.
It would be better not to use absolute tags here.
There was a problem hiding this comment.
What is the alternative? Before both the card and TLBC was created in h89.cpp, and could be directly linked. But here, when the parallel card is created, it does not have direct access to the tlbc.
There was a problem hiding this comment.
It’s still a device making assumptions about the surrounding system, which is fragile, and we’re trying to eliminate. If these signals can pass through the slot connector, they need to go through the slot device somehow.
It seems these are being added faster than existing ones are fixed. At this rate I think I’m going to need to come up with a way to trigger validation warnings for them.
There was a problem hiding this comment.
I received feedback from some other mame devs that resulted in my followup PR based on their suggestions - #13040 which you have also commented on. I guess we can have the conversation on that PR.
4 participants
tlb.cpp/.h:
cards.cpp:
h89bus.cpp:
sigmasoft_parallel_port.cpp:
h89.cpp: