Use js-yaml for environment-name parsing #82
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #81
Before, the
environment-name
was parsed using regex. Then, because of #78, we switched to a regex that also includes the line start, i.e.,^name:\s*(.*)
instead ofname:\s*(.*)
.This apparently doesn't work because the newlines
%0A
are not recognized bystring.match
.We now switch to yaml parsing with
js-yaml
. This now also reads environment files correctly that have inline commentsConda environment files also support jinja2, see here. This is out of scope for this project since adding a whole new yaml-conda parser in JS is too much effort and technical debt for just letting
setup-micromamba
infer the name of the environment. For these use cases, provide a customenvironment-name
as indicated by the error message.