Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare for jupyter releaser #10

Merged
merged 14 commits into from
Feb 17, 2023
Merged

Prepare for jupyter releaser #10

merged 14 commits into from
Feb 17, 2023

Conversation

janjagusch
Copy link
Collaborator

No description provided.

@simonbohnen
Copy link
Collaborator

It's complaining cause it's still finding a pre-release version number here, right?

@janjagusch
Copy link
Collaborator Author

janjagusch commented Feb 17, 2023 •
edited
Loading

It's complaining cause it's still finding a pre-release version number here, right?

It's actually complaining because of the opposite. It requires a pre-release version, but doesn't get one.

The version string is receives is 0.0.post4+g2765d57, which makes this piece of code raise an AssertionError:

https://github.com/jupyter-server/jupyter_releaser/blob/2ef7b7f60aef425273afe039f0f7b3651f193a5a/jupyter_releaser/util.py#L353-L354

@janjagusch janjagusch marked this pull request as ready for review February 17, 2023 17:13
@janjagusch janjagusch merged commit 496c6b4 into mamba-org:main Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@janjagusch @simonbohnen