Use correct url in metadata and mirrors

[Hind-M]

• Fix Redirection issues when using custom channels (e.g. https://repo.prefix.dev/emscripten-forge-dev) #3804
• Set metadata to original url instead of resolved/curl effective url

[jjerphan]

Thank you, @Hind-M.

Is it possible to have a slightly more precise and explicit PR title?

[jjerphan]

Thank you for adding the tests on PackageFetcher directly, this is much clearer!

This LGTM modulo one last suggestion.

---

If we make some of PackageFetcher's const getters public (which I think they should independently from this PR), we can complete the tests as hinted.

See f493d46 as a suggestion.

[Hind-M]

If we make some of PackageFetcher's const getters public (which I think they should independently from this PR), we can complete the tests as hinted.
See f493d46 as a suggestion.

I don't think these methods should be made public as they are only meant to be used internally in package_fetcher.cpp. The PackageFetcher class itself is also only used in Transaction which doesn't need other functions to be exposed.

[jjerphan]

I don't think these methods should be made public as they are only meant to be used internally in package_fetcher.cpp.

I think this is debatable¹ but not a priority for now.

You can merge this PR.

Footnotes

1. It would be useful to have a way to test some of those methods since some of them are not trivial (for instance url_path is not a getter returning const l-values of private members of an instance, but it conditionally constructing values at runtime). I cannot think of other simple way to test this than to change the access specifiers to public for now -- we could use some fixture friend (but that's far-fetch and overly complex) or we could #define private public at the beginning of this translation unit (but that's definitely evil). Opinions and ideas welcome! ↩