libmambapy: Switch build backend to scikit-build-core
#3802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Cristian Le <[email protected]>
Signed-off-by: Cristian Le <[email protected]>
LecrisUT
force-pushed
the
scikit-build-core
branch
from
e7d8cad to
3c886e9
Compare
LecrisUT
commented
Feb 5, 2025
| @@ -41,7 +41,8 @@ dependencies: | |||
| - cryptography | |||
| - securesystemslib | |||
| # libmambapy build dependencies | |||
| - scikit-build | |||
| - scikit-build-core | |||
| - setuptools-scm | |||
| - pybind11-stubgen <1.0 | |||
There was a problem hiding this comment.
Does conda still not have any integration with python build systems (PEP517)? Manually referencing them like this is very error-prone, particularly since some build dependencies are dynamically generated, setuptools-scm in this case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
setuptools-scmbecause it is simpler to configure for now. I don't think the reading version from python file is supported inscikit-build-coreyetsrc/libmambapy/bindingstobindingsbecause it interferes withpip install -e. It is cleaner to have the compilation source outside of the pure python files.Other than that it should be effectively identical.
I did not review the build system, but at least there is an immediate issue that needs to be resolved
This breaks all sdist builds because the archive starts from
libmambapyfolder. In practice, this is a purely developer option and there are neater ways to create one using targets instead. But if you really wish to keep it in that form, a solution is to make a symlink of the cmake folder.Closes #3798