Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Rerun pytest tests on main in case of failures #3769

Merged
merged 3 commits into from
Feb 4, 2025

Conversation

jjerphan
Copy link
Member

@jjerphan jjerphan commented Jan 24, 2025

Sporadic test failures due to reasons we cannot control (e.g. network) make an entire workflow fail.

This workflow need to be rerun manually, which takes extra time (up to 40 minutes) and distracts from work.

This proposes to automatically rerun test if they fail up to 3 times thanks to pytest-rerunfailures.

@jjerphan jjerphan added the release::ci_docs For PRs related to CI or documentation label Jan 24, 2025
@jjerphan jjerphan marked this pull request as ready for review January 24, 2025 09:31
@Hind-M
Copy link
Member

Hind-M commented Jan 24, 2025

As it may be very convenient to not restart failed tests manually, I don't think it's always due to network issues in our case. I guess this PR is opened due to the multiple recent tests failures that we are encountering, but in my opinion, we should rather investigate the root cause (as it seems to abort IIRC or terminate unexpectedly) and rerunning tests automatically after failure will prevent us from doing that thoroughly.

@JohanMabille
Copy link
Member

This could be done on the main branch once the PR has been merged though (I don't know if there is an easy way to do that).

Signed-off-by: Julien Jerphanion <[email protected]>

Co-authored-by: Johan Mabille <[email protected]>
@jjerphan jjerphan force-pushed the ci/rerun-pytest-tests-on-failure branch from 99053b8 to b88d551 Compare January 31, 2025 14:23
@jjerphan jjerphan changed the title ci: Rerun pytest tests in case of failures ci: Rerun pytest tests on main in case of failures Jan 31, 2025
@jjerphan jjerphan requested a review from JohanMabille January 31, 2025 18:03
Signed-off-by: Julien Jerphanion <[email protected]>

Co-authored-by: Hind Montassif <[email protected]>
@jjerphan jjerphan merged commit 8781dcc into mamba-org:main Feb 4, 2025
32 of 34 checks passed
@jjerphan jjerphan deleted the ci/rerun-pytest-tests-on-failure branch February 4, 2025 08:10
SandrineP pushed a commit to SandrineP/mamba that referenced this pull request Feb 6, 2025
Signed-off-by: Julien Jerphanion <[email protected]>
Co-authored-by: Johan Mabille <[email protected]>
Co-authored-by: Hind Montassif <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release::ci_docs For PRs related to CI or documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants