Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always add root_prefix/envs in envs_dirs #3692

Merged
merged 4 commits into from
Dec 18, 2024
Merged

Always add root_prefix/envs in envs_dirs #3692

merged 4 commits into from
Dec 18, 2024

Conversation

Hind-M
Copy link
Member

@Hind-M Hind-M commented Dec 16, 2024

Fix #3655

@Hind-M Hind-M added the release::bug_fixes For PRs fixing bugs label Dec 16, 2024
@Hind-M Hind-M changed the title Always add root_prefix/envs in envs_dirs Always add root_prefix/envs in envs_dirs Dec 16, 2024
Hind-M
Hind-M commented Dec 16, 2024
View reviewed changes
micromamba/src/common_options.hpp
@@ -40,9 +40,6 @@ init_channel_parser(CLI::App* subcom, mamba::Configuration& config);
void
load_channel_options(mamba::Context& ctx);

void
channels_hook(std::vector<std::string>& channels);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not used anywhere.

@Hind-M Hind-M marked this pull request as ready for review December 17, 2024 09:33
jjerphan
jjerphan approved these changes Dec 17, 2024
View reviewed changes
Copy link
Member

@jjerphan jjerphan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Thank you, @Hind-M.

I guess we can easily solve #3654 then.

Should we add a CLI test to ensure that this path is part of env location when {micro,}mamba info is used?

@JohanMabille JohanMabille merged commit 9c61b5f into mamba-org:main Dec 18, 2024
34 checks passed
@Hind-M Hind-M deleted the env_loc branch December 18, 2024 14:04
This was referenced Feb 5, 2025
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohanMabille JohanMabille JohanMabille approved these changes

@jjerphan jjerphan jjerphan approved these changes

Assignees
No one assigned
Labels
release::bug_fixes For PRs fixing bugs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

mamba info does not show correct/ all env location
3 participants
@Hind-M @JohanMabille @jjerphan