Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[win-64] Remove workaround #3398

Merged
merged 2 commits into from
Aug 12, 2024
Merged

[win-64] Remove workaround #3398

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2a2330a
Remove workaround (issue now fixed)
Hind-M Aug 8, 2024
c5a6a8d
Merge branch 'main' into win_restore
Hind-M Aug 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions .github/workflows/static_build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,17 +150,13 @@ jobs:
reproc-cpp-static>=14.2.4.post0
- name: build micromamba
shell: cmd /C call {0}
# Using D_DISABLE_CONSTEXPR_MUTEX_CONSTRUCTOR is a workaround to fix CI failure on win-64
# after updating runners to 20240603.1 image
# (cf. https://github.com/actions/runner-images/issues/10004#issuecomment-2153445161)
run: |
set CMAKE_PREFIX_PATH=.\vcpkg_installed\x64-windows-static-md;%CONDA_PREFIX%\Library
cmake -S . ^
-B build ^
-D CMAKE_CXX_COMPILER_LAUNCHER=sccache ^
-D CMAKE_C_COMPILER_LAUNCHER=sccache ^
-D CMAKE_MSVC_RUNTIME_LIBRARY="MultiThreadedDLL" ^
-D CMAKE_CXX_FLAGS=" /D_DISABLE_CONSTEXPR_MUTEX_CONSTRUCTOR" ^
-D CMAKE_BUILD_TYPE="Release" ^
-D BUILD_LIBMAMBA=ON ^
-D BUILD_STATIC=ON ^
Expand Down
Loading