Fixed create/install requiring pip install failing when the prefix have whitespaces on Windows

[Klaim]

Also adds tests checking this issue in the first commit. They fail for me on Windows 11 without the fix provided in the second commit.

I believe this should fix #1805 which was re-opened after #1828 re-introduced the issue.

[Klaim]

@chaubold pinged you as this should fix #1805 that was a regression from #1828

[chaubold]

Preventing the argument splitting by creating a vector<string> right away makes a lot of sense to me, thanks.

I have built it locally and tried the same use case that gave rise to my comment in #1828 and to reopening the issue. With the changes in this PR, everything works fine 👍 Nice one!

[jonashaag]

Does this also apply if we have a environment name with a space in environment.yml? (Is that even allowed?) If yes, shall we add a test as well?

[Klaim]

Does this also apply if we have a environment name with a space in environment.yml? (Is that even allowed?) If yes, shall we add a test as well?

I didn't consider that case, I'll add a test.

[Klaim]

@jonashaag For some unclear reason your changes don't pass for me (windows 11) because the type of prefix is WindowsPath('...') and can't be passed as is to that function so f"{prefix}" is used as a conversion to string. I'm not sure why it passes on CI, but maybe it's a python version mismatch.

[Klaim]

The initial fix should cover any prefix value provided (as long as it have been correctly parsed before reaching that part of the code). I added the test.

[wolfv]

Thanks @Klaim !

[jonashaag]

@jonashaag For some unclear reason your changes don't pass for me (windows 11) because the type of prefix is WindowsPath('...') and can't be passed as is to that function so f"{prefix}" is used as a conversion to string. I'm not sure why it passes on CI, but maybe it's a python version mismatch.

The proper way would be to use str.

[chaubold]

Are there any plans to build a 0.25.2 release with this fix?