Fix pip execution in environments with spaces in path (#1805) #1815
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thanks! nice fix. |
Member
|
Hmm, it seems to have broken things on Windows for this Github Action: https://github.com/mamba-org/powerloader/runs/7553314516?check_suite_focus=true @chaubold |
Member
|
I think it may be related to using |
Contributor
Author
|
Oh, good catch, thanks for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Conda executes pip via
python -m pip install ...when installing pip dependencies into the environment. Mamba is usingpip installdirectly, but that does not work in environments with spaces in the path. This PR makes sure mamba als usespython -m pip install ...during the package installation process.See #1805 for a longer discussion.