-
Notifications
You must be signed in to change notification settings - Fork 365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use standard C++ filesystem API only #1665
Conversation
f80df10
to
a4d8879
Compare
Here is where I am at:
|
95385c6
to
ca555a9
Compare
This version compiles and run on my Windows which is set to have UTF-8 by default in everywhere. However only the libmamba tests can be run, for some reason the |
@Klaim it looks like one last Unicode test fails on |
Yes, it's the one revealing the need for wrapping the path type. I was doing that but I'm starting to think it might be more complicated than just using a |
afa0559
to
406556e
Compare
ceff6d4
to
bd14610
Compare
5e909d9
to
3582265
Compare
cc99827
to
c09f0e0
Compare
This is to enable using the string functions without including everything.
b240fb4
to
6fea5fa
Compare
(rebased over CI not reporting issues that should have been reported, which I expect to fail because I added a test that should fail before I will push more commits). |
OK Now the test fails as it should. |
This reverts commit 4a4c657.
… (Windows STL bug)
3ee1edf
to
c694e3c
Compare
looks like my workaround for cleanup incoming |
c694e3c
to
49af91f
Compare
Thanks for pushing this through until the end! |
See rationale in libmamba/include/mamba/core/mamba_fs.hpp