Show reason for Multi-download failure (#1652)

Co-authored-by: syslaila <[email protected]>
mamba-org · May 10, 2022 · 070b6e3 · 070b6e3
1 parent 6cb7215
commit 070b6e3
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 5 deletions.
diff --git a/libmamba/include/mamba/core/fetch.hpp b/libmamba/include/mamba/core/fetch.hpp
@@ -78,6 +78,7 @@ namespace mamba
 
         void set_result(CURLcode r);
         bool finalize();
+        std::string get_transfer_msg();
 
         bool can_retry();
         CURL* retry();
@@ -88,6 +89,7 @@ namespace mamba
         CURLcode result;
         bool failed = false;
         int http_status = 10000;
+        char* effective_url = nullptr;
         curl_off_t downloaded_size = 0;
         curl_off_t avg_speed = 0;
         std::string final_url;

diff --git a/libmamba/src/core/fetch.cpp b/libmamba/src/core/fetch.cpp
@@ -643,15 +643,12 @@ namespace mamba
 
     bool DownloadTarget::finalize()
     {
-        char* effective_url = nullptr;
-
         avg_speed = get_speed();
         curl_easy_getinfo(m_handle, CURLINFO_RESPONSE_CODE, &http_status);
         curl_easy_getinfo(m_handle, CURLINFO_EFFECTIVE_URL, &effective_url);
         curl_easy_getinfo(m_handle, CURLINFO_SIZE_DOWNLOAD_T, &downloaded_size);
 
-        LOG_INFO << "Transfer finalized, status " << http_status << " [" << effective_url << "] "
-                 << downloaded_size << " bytes";
+        LOG_INFO << get_transfer_msg();
 
         if (can_retry())
         {
@@ -719,6 +716,14 @@ namespace mamba
         return ret;
     }
 
+    std::string DownloadTarget::get_transfer_msg()
+    {
+        std::stringstream ss;
+        ss << "Transfer finalized, status: " << http_status << " [" << effective_url << "] "
+           << downloaded_size << " bytes";
+        return ss.str();
+    }
+
     /**************************************
      * MultiDownloadTarget implementation *
      **************************************/
@@ -803,7 +808,8 @@ namespace mamba
                     {
                         if (failfast && current_target->ignore_failure() == false)
                         {
-                            throw std::runtime_error("Multi-download failed.");
+                            throw std::runtime_error("Multi-download failed. Reason: "
+                                                     + current_target->get_transfer_msg());
                         }
                     }
                 }