Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update labextension to JupyterLab 3 #111

Merged
merged 5 commits into from
Feb 28, 2021
Merged

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Nov 26, 2020

Take two for #89

$ jupyter labextension list
JupyterLab v3.0.0rc10
/home/jtp/miniforge3/envs/gator/share/jupyter/labextensions
        @mamba-org/gator-lab v2.0.0-rc.0 enabled OK (python, mamba_gator)

The coveralls has been removed as it is broken.

TODO

@github-actions
Copy link

Binder 👈 Launch a binder notebook on the branch jtpio/gator/lab3

@jtpio
Copy link
Member Author

jtpio commented Nov 26, 2020

We might want to have this PR in first: jupyterlab-contrib/jupyterlab_toastify#13

To help align the versions of React.

@jtpio
Copy link
Member Author

jtpio commented Nov 26, 2020

Decide whether to keep the tgz, or only the lab3 federated bundle and only one labextension dir,

It might not make sense to keep the tgz as part of the data files, if we end up updating all compatibility ranges to 3.0.0 for the lab packages. 3.0 users will use the federated bundle directly.

The tgz is only useful to lab 1 and 2 users.

For lab 2 users, the readme can mention the extra command to install the extension:

jupyter labextension install @mamba-org/gator-lab

setup.py Outdated
(
"share/jupyter/nbextensions/mamba_gator",
classic_folder,
"**" # TODO: filter .py files
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: fix this

@fcollonval
Copy link
Member

We might want to have this PR in first: fcollonval/jupyterlab_toastify#13

To help align the versions of React.

Done 😉

@fcollonval
Copy link
Member

* Remove `resolutions`

This seems to be done.

@fcollonval fcollonval marked this pull request as ready for review February 28, 2021 10:52
@fcollonval fcollonval merged commit e53ce8f into mamba-org:master Feb 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants