Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue where the Groupable did not properly support AutoWidth and AutoHeight #34

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

dulbrich
Copy link

@dulbrich dulbrich commented May 26, 2016

Useful when making cards and you don't know how tall the text in the middle is going to be.
screen shot 2016-05-26 at 4 21 47 pm

@tim12s
Copy link
Contributor

tim12s commented May 27, 2016

Hi,

Can you add your ViewController as a test case - CardViewControllerDemo? Something like that.

Thanks
-Tim

@mamaral
Copy link
Owner

mamaral commented May 27, 2016

As soon as I can I take a look at the details and update you, but on first glance I noticed how different the style/format is from the rest of the project. I'd like to keep everything consistent, i.e. parens around math to make order of operations clear to readers, declaring 0 as 0.0 to make reading it and recognizing it as a float clearer, spaces between operands like x / 2.0, etc.

@dulbrich
Copy link
Author

dulbrich commented Jun 2, 2016

Sorry for the slow response. My wife and I were welcoming our firstborn child into the world and everything else took the back burner...

@mamaral, I tried to match the style as best I could. Let me know if you'd like anything else changed.

@tim12s, I included an example of how one might create cards using only this library.
screen shot 2016-06-02 at 1 19 10 pm

And for a bit of fun:

screen shot 2016-06-02 at 2 19 47 pm

@mamaral
Copy link
Owner

mamaral commented Jun 2, 2016

@dulbrich Congrats!! I've been quite busy as well, so I'll take a look at this once more as soon as I get a chance but the style fixes look perfect.

@dulbrich
Copy link
Author

dulbrich commented Aug 9, 2016

@mamaral

@mamaral
Copy link
Owner

mamaral commented Aug 9, 2016

@dulbrich A bunch has changed in the last couple of months - if you can resolve the conflicts I'll get it merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants