Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calculate package digest on first use. #436

Merged
merged 2 commits into from
Dec 31, 2024
Merged

Conversation

fschulze
Copy link
Contributor

This allows for faster startup times in case no template is used.

Helps with things like argcomplete or faster responses for errors that happen before templates are used. In my project the calculation of pkg_digest takes almost one second. It might be possible to use something different then packages_distributions from importlib.metadata, which is the slow part, but I couldn't find a suitable replacement.

This allows for faster startup times in case no template is used.
@coveralls
Copy link

coveralls commented Dec 31, 2024

Pull Request Test Coverage Report for Build 12558875756

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 9 of 9 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 92.36%

Totals Coverage Status
Change from base Build 12455853721: 0.03%
Covered Lines: 3920
Relevant Lines: 4170

💛 - Coveralls

@malthe malthe merged commit 90c1653 into malthe:master Dec 31, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants