Skip to content

Only enable button when upload is complete #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Only enable button when upload is complete #64

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,8 +53,6 @@ export default class PhotoUpload extends React.Component {

// get image from image picker
ImagePicker.showImagePicker(this.options, async response => {
this.setState({buttonDisabled: false})

let rotation = 0
const {originalRotation} = response

Expand All @@ -64,15 +62,15 @@ export default class PhotoUpload extends React.Component {
if (response.didCancel) {
console.log('User cancelled image picker')
if (this.props.onCancel) this.props.onCancel('User cancelled image picker')
return
return this.setState({ buttonDisabled: false })
} else if (response.error) {
console.log('ImagePicker Error: ', response.error)
if (this.props.onError) this.props.onError(response.error)
return
return this.setState({ buttonDisabled: false })
} else if (response.customButton) {
console.log('User tapped custom button: ', response.customButton)
if (this.props.onTapCustomButton) this.props.onTapCustomButton(response.customButton)
return
return this.setState({ buttonDisabled: false })
}

let { maxHeight, maxWidth, quality, format } = this.state
Expand Down Expand Up @@ -107,7 +105,8 @@ export default class PhotoUpload extends React.Component {
const photoData = await RNFS.readFile(filePath, 'base64')
let source = { uri: resizedImageUri.uri }
this.setState({
avatarSource: source
avatarSource: source,
buttonDisabled: false
})

// handle photo in props functions as data string
Expand Down