fix(ios): bump @tauri-apps/api to 2.11 so JS matches the Rust tauri crate - #228
Conversation
…rate The mobile-resume/viewport fix (#225) bumped the Rust tauri family 2.10.3 -> 2.11.0 (lockfile only) to inherit the WKWebView auto-reload, but left @tauri-apps/api pinned at 2.10.1 in both apps. `cargo tauri ios build` enforces that the NPM package and Rust crate share a major/minor, so both TestFlight lanes failed on main: Found version mismatched Tauri packages... tauri (v2.11.0) : @tauri-apps/api (v2.10.1) Pin @tauri-apps/api to ~2.11.0 in identity-wallet and admin-companion and regenerate the lockfiles (both resolve 2.11.1). Pinning to the 2.11 minor (rather than the wallet's prior loose ^2) keeps the JS API locked to the Rust crate's minor so a future 2.12 publish can't silently re-introduce the mismatch. Frontend type-check and unit tests pass for both apps. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017minW9TbfkkZ1vKp5L1Y1B
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (2)
📜 Recent review details⏰ Context from checks skipped due to timeout. (4)
🧰 Additional context used🔍 Remote MCPRelevant review context
This looks like a version-alignment fix rather than a functional frontend change; the main review check is whether the Rust-side 🔇 Additional comments (2)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe pull request updates ChangesTauri API Version Alignment
Estimated code review effort: 1 (Trivial) | ~2 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Problem
CI on
mainis red. The Linux PDS lane (ci.yml) is green on the tip, but both macOS TestFlight lanes — iOS · TestFlight and Admin Companion · TestFlight, which run on every push tomain— failed on7a0da74(#225).Failed job log:
Root cause
#225 ("Fix mobile resume blanking and viewport/scroll layout bugs") deliberately bumped the Rust
taurifamily 2.10.3 → 2.11.0 (lockfile only) to inherit the WKWebView auto-reload that fixes resume-blanking — but left the npm@tauri-apps/apipinned at 2.10.1 in both apps.cargo tauri ios buildrefuses to build when the JS API and Rust crate differ on major/minor, so the IPA build aborts before signing. The Linux gate (just ci-pds) excludes both iOS apps by design, so it never caught this.Fix
Bump
@tauri-apps/apito~2.11.0in both apps and regenerate the lockfiles (both resolve 2.11.1, same 2.11 minor as the Rust crate):apps/identity-wallet/package.json+pnpm-lock.yaml(^2→~2.11.0)apps/admin-companion/package.json+pnpm-lock.yaml(~2.10.0→~2.11.0)Pinning to the
2.11minor rather than the wallet's prior loose^2keeps the JS API locked to the Rust crate's minor, so a future 2.12 publish can't silently re-introduce the same mismatch. This matches the admin app's existing~2.MINOR.0pinning discipline.Validation
Run locally (the macOS
xcodebuild/signing step can't run on Linux, but this targets the exact version-parity check that failed — now 2.11 vs 2.11):pnpm install --frozen-lockfilepasses for both apps (CI's install step — lockfile in sync with package.json)pnpm check(svelte-check): 0 errors, both appspnpm test: 65/65 (identity-wallet) and 96/96 (admin-companion) pass🤖 Generated with Claude Code
Generated by Claude Code