Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't autodetect SSE2 #24

Merged
merged 1 commit into from
Jan 15, 2025
Merged

Don't autodetect SSE2 #24

merged 1 commit into from
Jan 15, 2025

Conversation

tornaria
Copy link
Contributor

Instead, test SSE2 in the compiler.

This doesn't make a difference on x86_64 as sse2 is always present.
To enable sse2 for i686, one can add -msse2 to CFLAGS.

This partly addresses #9. In the current version, simd flags would be leaked
from the build box, even unused ones as avx2 and avx512.

Instead, test __SSE2__ in the compiler.

This doesn't make a difference on x86_64 as sse2 is always present.
To enable sse2 for i686, one can add `-msse2` to `CFLAGS`.
@malb
Copy link
Owner

malb commented Jan 15, 2025

This is two separate changes in one commit, right? I'm not challenging that, I'm just trying to make sure I follow what is being proposed here:

  • don't detect SSE2
  • don't leak SIMD flags

@tornaria
Copy link
Contributor Author

This is two separate changes in one commit, right? I'm not challenging that, I'm just trying to make sure I follow what is being proposed here:

* don't detect SSE2

* don't leak SIMD flags

Yes. But it's really one change, not detecting sse2; and then there are no simd flags to leak.

Since m4ri only uses sse2, there's nothing to loose here (x86_64 includes sse2).

@malb malb merged commit 6b1c4aa into malb:master Jan 15, 2025
1 check passed
@malb
Copy link
Owner

malb commented Jan 15, 2025

Ta!

@tornaria tornaria deleted the sse2 branch January 15, 2025 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants