Add mypy workflow #99
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
These are a lot of errors... |
Contributor
|
Currently 160 errors in mypy, we need to fix those before merging. |
Contributor
|
I fixed most of the errors in malsim, but I realized I missed ./tests. This PR is work in progress still so I will put it into Draft. |
Contributor
|
Now all CIs are passing. I had to do a few things:
I think this is mergeable. It does give mypy support for most of the code base. We should create an issue in the maltoolbox repo so we don't have to use 'ignore missing imports'. We should also typehint (or deprecate) the gym_envs. |
- Add typehints for all files except for gym_envs.py - mypy runs without errors - remove the MalSimEnv baseclass for malsim vectorized obs env - remove logging methods from malsim vectorized obs env as cleanup
…pdating maltoolbox
…t.toml instead of in bash commmand
mrkickling
approved these changes
Jun 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the changes happening in #87, types are a bit out of sync in places. This adds mypy in strict mode as a CI job. Ideally, this mypy workflow and the ruff one would exist only in the mal-toolbox repo and be used here as reusable workflows. This will give a common static analysis coverage on both projects (and maybe others too).