-
Notifications
You must be signed in to change notification settings - Fork 2
Adapt to maltoolbox 0.2.0 #94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The test that failed is because the order of choices for the BFS attacker are not the same anymore. Why this happens is worth looking into, but probably it is just because the observations are built up differently. I will compare two attack graphs (one from mal-toolbox 0.1.0 and one from 0.2.0) and see if that gives any clues. If nothing seems fishy I will just rewrite the test to match the new order. |
|
The main thing I noticed is that the IDs are not the same in the new 0.2.0 attack graph compared to the old 0.1.0 attack graph (created from the same model). Does this seem normal @andrewbwm ? Other than that the two attack graphs seem identical (I have not checked thoroughly) so I will just rewrite the test on monday and then put this branch in review. |
That is normal because attack steps are probably created in a slightly different order now, but it shouldn't really matter. Also, you don't need to adjust their ids between versions, there is no expectation about the ordering of ids. They just need to be unique. It's also a good idea if we have the tests not really depend too much on ids, but rather on names. Not sure which test this is but we can have a look at it if it isn't obvious how to rewrite it to use names. |
Good, good! |
The intention is to merge this to main and create a release before we are done with #87, just to support maltoolbox 0.2.0 as soon as possible in the simulator.