Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Utilize com.android.documentsui as file picker. #717

Open
RokeJulianLockhart opened this issue Jul 24, 2024 · 3 comments
Open

Utilize com.android.documentsui as file picker. #717

RokeJulianLockhart opened this issue Jul 24, 2024 · 3 comments

Comments

@RokeJulianLockhart
Copy link

RokeJulianLockhart commented Jul 24, 2024

Is your feature request related to a problem?

Currently, it's custom:

Screenshot_20240724-114025

This prevents it accessing https://developer.android.com/training/data-storage/shared/documents-files, whereas utilizing the native FP would.

Describe the solution you'd like

Utilize the native file picker (com.android.documentsui):

Screenshot_20241003-124054

Describe alternatives you've considered

Unfortunately, the ability to access such virtual directories cannot be implemented by 3rd-party applications, if zhanghai/MaterialFiles#1215 (comment) applies to all virtual folders (rather than merely system-provided, sensitive ones, like Bug Reports).

Additional context

@RokeJulianLockhart RokeJulianLockhart changed the title Utilize com.android.documentsui as file picker Utilize com.android.documentsui as file picker. Jul 24, 2024
@maks
Copy link
Owner

maks commented Jul 24, 2024

Just to clarify, are you requesting this for specifying the location of a local git repo or to select files to add to a existing local repo?

@RokeJulianLockhart
Copy link
Author

#717 (comment)

@maks, both - wherever there is a file picker. That is, of course, unless you require the ability to add something custom to its GUI.

@maks
Copy link
Owner

maks commented Jul 25, 2024

@RokeJulianLockhart ok thanks for clarifying. Unfortunately for the local repo location, that won't be possible because JGit, the underlying git library used in MGit requires actual file handles to the selected repo directory, which is not available by using the Intent based file chooser API that you referenced, as that will only return a uri for the selected file or directory tree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants