This repository was archived by the owner on Jul 30, 2026. It is now read-only.
fix(tui): use client catalog metadata - #85
Merged
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (6)
代码审查摘要将颜色解析与分配逻辑从 变更详情颜色逻辑提取与重构
预估代码审查难度🎯 3 (Moderate) | ⏱️ ~25 minutes 可能相关的 PR
小诗
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Owner
Author
|
/juya review |
|
OpenCodeReview: No comments generated. Looks good to me. |
makoMakoGo
force-pushed
the
codex/remove-openclaw-emoji
branch
from
June 30, 2026 12:44
6d05df1 to
3cc5e75
Compare
makoMakoGo
force-pushed
the
codex/remove-openclaw-emoji
branch
2 times, most recently
from
June 30, 2026 13:24
14115c9 to
d2cef6e
Compare
makoMakoGo
force-pushed
the
codex/remove-openclaw-emoji
branch
from
June 30, 2026 15:24
d2cef6e to
9624519
Compare
makoMakoGo
marked this pull request as ready for review
June 30, 2026 15:36
This was referenced Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root Cause
TUI client metadata was split across the generated client catalog and local helper hardcodes. Display names mostly used the catalog, but OpenClaw had a special emoji branch. Client colors used a separate TUI match table even though the catalog already stores validated #RRGGBB colors. Color policy also lived in widgets.rs, which made colors.rs depend back on widgets for provider shade behavior.
User Impact
Known client names and colors now share the client catalog as their source of truth. Some TUI client colors intentionally switch to catalog values where the old TUI table disagreed, including OpenCode and Droid.
Structure
The TUI color seam now points one way: app/stats/model shade code call tui::colors, tui::colors reads raw config values and catalog metadata, and widgets.rs no longer owns color policy. Config remains a raw settings module and no longer parses ratatui colors itself.
Validation
Summary by CodeRabbit
New Features
Bug Fixes