Record local branch decisions - #40
Conversation
Reviewer's GuideDocuments branch-specific context and architectural decisions for the personal/local-clients fork by adding a branch context file and five concise ADRs that codify local semantics around synthetic usage, error handling, client identities, workspaces, and future client/aggregation/TUI boundaries. File-Level Changes
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Code Review
This pull request introduces a branch context document (CONTEXT.md) and five Architecture Decision Records (ADRs 0001-0005) that establish vocabulary, architectural boundaries, and design decisions for the personal/local-clients branch of tokscale. The review feedback suggests minor improvements for consistency and formatting, specifically changing 'Synthetic' to lowercase 'synthetic' in ADR 0002 and wrapping 'cwd' in backticks in CONTEXT.md and ADR 0004 to clearly denote it as a technical term.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
关联 issue:Closes #39
变更
CONTEXT.md,记录personal/local-clients分支的目标、词汇、已定决策和非目标。docs/adr/下 5 条短 ADR:原因
我们会频繁 merge 上游,所以需要把本分支的 load-bearing decisions 写在 repo 内,而不是靠口头记忆。尤其是
synthetic.new与 Claude Codemodel = "<synthetic>"placeholder 的语义必须分开,否则后续 agent 或 bot review 很容易把它们混成一个概念。验证
git diff --check依赖关系
这个 PR 应先于删除
synthetic.new的实现 PR 合入,用作后续 review 和冲突处理的本地决策依据。Summary by Sourcery
Document local branch context and architectural decisions for the personal/local-clients fork to guide future changes and upstream merges.
Documentation: