perf(tui): project source filters without rescanning - #182
Conversation
|
Warning Review limit reached
Next review available in: 5 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (23)
WalkthroughPR 将 TUI 的启动来源全集与会话选择分离,支持按客户端子集本地重投影,并升级 schema-41 缓存以持久化和校验 canonical 聚合状态。对话框变更改为关闭后应用,失败时回滚。 ChangesTUI 来源选择与投影
Estimated code review effort: 5 (Critical) | ~120 minutes Sequence Diagram(s)sequenceDiagram
participant User
participant SourcePicker
participant App
participant ProjectionStore
participant TuiAcc
User->>SourcePicker: 修改来源选择
SourcePicker->>App: 标记 dialog_source_changed
User->>App: 关闭对话框
App->>ProjectionStore: project(group_by, selected_clients)
ProjectionStore->>TuiAcc: 按 selected clients 投影
TuiAcc-->>App: 返回 UsageData
Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
d17a693 to
c4bea52
Compare
|
@codex review |
|
Codex Review: Didn't find any major issues. 👍 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Merging this PR will degrade performance by 14.19%
Warning Please fix the performance issues or acknowledge them on CodSpeed. Performance Changes
Tip Investigate this regression by commenting Comparing |
Separate the fixed scan universe from session-local source selection, remove blocking reload fallbacks, and persist source-aware canonical projection state for local Source and Group By changes.
c4bea52 to
899243b
Compare
Summary
Validation
cargo test -p tokscale-cli— 885 passed, 1 ignoredcargo test -p tokscale-core— 1496 passed, 4 ignoredcargo clippy -p tokscale-core -p tokscale-cli --all-targets -- -D warningscargo fmt --all -- --checkcargo build -p tokscale-cli --releasePerformance
Five-run medians against the installed
tokscale 4.8.0binary:The schema-41 TUI bundle grows from 3,309,696 to 5,044,486 bytes for the canonical source-aware projection state.
Summary by CodeRabbit
新功能
错误修复
文档