Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update go dependencies and require go 1.17 #336

Merged
merged 1 commit into from
Sep 27, 2023
Merged

Update go dependencies and require go 1.17 #336

merged 1 commit into from
Sep 27, 2023

Conversation

grisu48
Copy link
Contributor

@grisu48 grisu48 commented Aug 29, 2023 •
edited
Loading

Require go 1.17 as needed by golang.org/x/sys/unix/syscall and update all go dependencies to current versions, which are not pinned.

Proposed fix for #335

@makew0rld
Copy link
Owner

Thanks for this fix. Please don't update cview as it may cause UI breaking changes. It's pinned to a specific commit on purpose. Please also check semantic versioning, for example termenv may have breaking changes as well according to the semantic versioning spec. Otherwise I will be happy to merge this.

@grisu48
Copy link
Contributor Author

grisu48 commented Sep 4, 2023 •
edited
Loading

Thanks for the review! I updated the PR accordingly.

cview had indeed breaking changes. For the other dependencies, I used the freshly build amfora binary and could not find any regressions in basic usage.

@grisu48
Update go dependencies and require go 1.17
7a0c4b4 
Require go 1.17 as needed by golang.org/x/sys/unix/syscall and update
all go dependencies to current versions, which are not pinned

Signed-off-by: phoenix <phoenix>
@grisu48
Copy link
Contributor Author

grisu48 commented Sep 26, 2023

@makew0rld do those change address your concerns now?

@makew0rld makew0rld merged commit 818604f into makew0rld:master Sep 27, 2023
3 checks passed
@makew0rld
Copy link
Owner

Thanks!

@makew0rld makew0rld mentioned this pull request Sep 27, 2023
Closed
makew0rld added a commit that referenced this pull request Sep 27, 2023
@makew0rld
doc for #336 and #319
f3cf73d
@grisu48
Copy link
Contributor Author

grisu48 commented Sep 28, 2023

Thanks to you 🙂

@grisu48 grisu48 deleted the gomod branch September 28, 2023 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@grisu48 @makew0rld