Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Download choice modal loses focus when non-text response is received from CLI URL #283

Closed
makew0rld opened this issue Dec 11, 2021 · 3 comments
Closed

Download choice modal loses focus when non-text response is received from CLI URL #283

makew0rld opened this issue Dec 11, 2021 · 3 comments
Labels
bug Something isn't working
Milestone
v1.10.0

Comments

@makew0rld
Copy link
Owner

Run amfora gemini.thebackupbox.net/radio. The URL is to a page that returns audio/mpeg. The page is loading, then the download choice modal pops up, then the new tab page loads behind it and takes focus, meaning the user can't select a download choice.
@makew0rld makew0rld added the bug Something isn't working label Dec 11, 2021
@makew0rld
Copy link
Owner Author

Related to #281, if the modal was blocking this wouldn't happen

@makew0rld makew0rld mentioned this issue Dec 11, 2021
Closed
@makew0rld makew0rld added this to the v1.10.0 milestone Dec 11, 2021
awfulcooking added a commit to awfulcooking/amfora that referenced this issue Dec 12, 2021
@awfulcooking
Do dlChoice modal in a blocking fashion [fixes makew0rld#283]
1d45c79
awfulcooking added a commit to awfulcooking/amfora that referenced this issue Dec 12, 2021
@awfulcooking
Do the other dlChoice calls blocking, too [really fixes makew0rld#283]
a7c27c6
@makew0rld makew0rld mentioned this issue Dec 13, 2021
Merged
@mntn-xyz
Copy link
Contributor

mntn-xyz commented Dec 14, 2021 •
edited by makew0rld
Loading

This also happens if the URL triggers an external handler, for instance amfora https://example.com causes the Info dialog to be stuck on screen after the configured browser is opened.

@makew0rld makew0rld mentioned this issue Dec 22, 2021
Open
@makew0rld
Copy link
Owner Author

Closed by #284, thanks @awfulcooking!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
v1.10.0
Development

No branches or pull requests
2 participants
@makew0rld @mntn-xyz