-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Home
Sam Joseph edited this page Sep 28, 2015
·
9 revisions
- correct semantics for form mark up (I have a feeling this is an issue in Bookmark manager too) - specifically using a for attribute in labels (mozilla's guide)[https://developer.mozilla.org/en-US/docs/Web/Guide/HTML/Forms/How_to_structure_an_HTML_form] ++++
- read over your pull request before finishing. the final process should be reading the created pull request and making changes that are seen before sending it to us, as otherwise we waste time going over indentation, comments, and unnecessary files +++
- update README to indicate install process for other developers (and other stuff)++
- unused files +
- Prefer Sinatra::Application +
- avoid old should rspec syntax
- RSpec features scenarios (need some examples of what we think is best)
- integration/acceptance tests (avoid database testing in acceptance tests --> need to update tutorial)
- need unit tests for datamapper
- confusion over flash.now
- ensuring all feature tests are in features directory
- extract database setup to separate file
- correct indenting and spacing
- don't use divs
- before blocks don't need each (set to that by default)
- correct semantics for form mark up (I have a feeling this is an issue in Bookmark manager too)
- split routes into a controller file/many controller files
- using correct database for testing
- dead code in comments
- ensure test related stuff in test group, e.g. capybara
- support files in spec_helper
- gnarly helper methods. Check out: https://gist.github.com/ptolemybarnes/2dfda607b85d01e113b0