[WEB-3043]chore: removed guest assignees from issue filters #6402
Conversation
WalkthroughThe pull request introduces a Changes
Possibly related PRs
Suggested Labels
Suggested Reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (2)
web/app/[workspaceSlug]/(projects)/projects/(detail)/[projectId]/views/(detail)/[viewId]/header.tsx (2)
249-249: Consider adding null check for projectId.While the current implementation works, it's good practice to add a null check for route parameters.
-projectId={projectId.toString()} +projectId={projectId?.toString()}
Line range hint
75-83: Consider caching the filtered assignee list.Since the filtering of guest users is performed on every render, consider memoizing the
assigneeIdslist usinguseMemoto optimize performance, especially for projects with many members.+const assigneeIds = useMemo(() => memberIds?.filter((id) => { if (projectId) { const memberDetails = getProjectMemberDetails(id, projectId); return memberDetails?.role !== EUserPermissions.GUEST; } return true; }), + [memberIds, projectId, getProjectMemberDetails] +);
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
web/app/[workspaceSlug]/(projects)/projects/(detail)/[projectId]/views/(detail)/[viewId]/header.tsx(1 hunks)web/core/components/issues/filters.tsx(1 hunks)web/core/components/issues/issue-layouts/filters/header/filters/filters-selection.tsx(4 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: Analyze (javascript)
- GitHub Check: Analyze (python)
🔇 Additional comments (2)
web/core/components/issues/issue-layouts/filters/header/filters/filters-selection.tsx (1)
160-160: Verify the impact of filtering guest assignees.The change to use
assigneeIdsinstead ofmemberIdsmight affect existing issues that were already assigned to guest users.✅ Verification successful
The change to use
assigneeIdsis a security improvementThe switch from
memberIdstoassigneeIdsis actually implementing proper guest user filtering, ensuring that guest users cannot be assigned to issues. This aligns with the backend's existing guest user validation and improves access control. The change does not negatively impact existing issues but rather enforces proper security constraints.🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Check for any existing issues assigned to guest users # that might be affected by this change # Find all guest users in the project echo "Checking for issues assigned to guest users..." ast-grep --pattern 'assignees.includes($GUEST_ID)'Length of output: 155
Script:
#!/bin/bash # Search for memberIds and assigneeIds usage echo "Searching for memberIds usage..." rg "memberIds" -A 2 -B 2 echo -e "\nSearching for assigneeIds usage..." rg "assigneeIds" -A 2 -B 2 echo -e "\nSearching for guest user related code..." rg -i "guest.*user|guest.*member" -A 2 -B 2Length of output: 54566
web/core/components/issues/filters.tsx (1)
123-123: LGTM!The projectId prop is correctly passed to the FilterSelection component.
| // filter guests from assignees | ||
| const assigneeIds = memberIds?.filter((id) => { | ||
| if (projectId) { | ||
| const memeberDetails = getProjectMemberDetails(id, projectId); | ||
| const isGuest = (memeberDetails?.role || EUserPermissions.GUEST) === EUserPermissions.GUEST; | ||
| if (isGuest && memeberDetails) return false; | ||
| } | ||
| return true; | ||
| }); |
There was a problem hiding this comment.
🛠️ Refactor suggestion
Fix typos and optimize the guest filtering logic.
The guest filtering implementation has a few issues:
- Typo in variable name
memeberDetails->memberDetails - Redundant null check after using the variable
- The role access can be simplified
const assigneeIds = memberIds?.filter((id) => {
if (projectId) {
- const memeberDetails = getProjectMemberDetails(id, projectId);
- const isGuest = (memeberDetails?.role || EUserPermissions.GUEST) === EUserPermissions.GUEST;
- if (isGuest && memeberDetails) return false;
+ const memberDetails = getProjectMemberDetails(id, projectId);
+ return memberDetails?.role !== EUserPermissions.GUEST;
}
return true;
});📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| // filter guests from assignees | |
| const assigneeIds = memberIds?.filter((id) => { | |
| if (projectId) { | |
| const memeberDetails = getProjectMemberDetails(id, projectId); | |
| const isGuest = (memeberDetails?.role || EUserPermissions.GUEST) === EUserPermissions.GUEST; | |
| if (isGuest && memeberDetails) return false; | |
| } | |
| return true; | |
| }); | |
| // filter guests from assignees | |
| const assigneeIds = memberIds?.filter((id) => { | |
| if (projectId) { | |
| const memberDetails = getProjectMemberDetails(id, projectId); | |
| return memberDetails?.role !== EUserPermissions.GUEST; | |
| } | |
| return true; | |
| }); |
Description
Removed guest users from issues filters.
Type of Change
References
WEB-3043
Summary by CodeRabbit
New Features
Improvements
The changes introduce more granular control over issue filtering and assignment within project contexts, providing a more tailored user experience.