chore: minor improvements related to members dropdown and project members list

[prateekshourya29]

Description

Type of Change

• Bug fix (non-breaking change which fixes an issue)
• Feature (non-breaking change which adds functionality)
• Improvement (change that would cause existing functionality to not work as expected)
• Code refactoring
• Performance improvements
• Documentation update

Screenshots and Media (if applicable)

Test Scenarios

References

Summary by CodeRabbit

• New Features

  • Added optional memberIds property to Member Dropdown and Member Options components, enabling more flexible member selection

• Bug Fixes

  • Improved error handling in project member management
  • Enhanced user feedback with more descriptive error messages when:
    • Attempting to leave a project
    • Trying to remove a project member
    • Changing project member roles

[coderabbitai]

Walkthrough

The pull request introduces modifications to several components related to member and project management. The changes primarily focus on adding a new optional memberIds prop to dropdown components, enhancing their flexibility in displaying member options. Additionally, the PR updates error handling and toast notifications in project member and settings components to provide more descriptive error messages when performing actions like leaving a project or changing member roles.

Changes

File	Change Summary
web/core/components/dropdowns/member/index.tsx	Added optional memberIds?: string[] prop to MemberDropdown component
web/core/components/dropdowns/member/member-options.tsx	Added optional memberIds prop with logic to prioritize passed member IDs over existing fetching methods
web/core/components/project/member-list-item.tsx	Updated error handling and toast notifications for project member removal
web/core/components/project/settings/member-columns.tsx	Modified error toast notification for role update to be more specific

Sequence Diagram

sequenceDiagram
    participant User
    participant MemberDropdown
    participant MemberOptions
    
    User->>MemberDropdown: Open dropdown
    MemberDropdown->>MemberOptions: Pass memberIds (if provided)
    alt memberIds provided
        MemberOptions->>MemberOptions: Use passed memberIds
    else no memberIds
        MemberOptions->>MemberOptions: Fetch members by projectId/workspaceId
    end
    MemberOptions-->>User: Display member options

Loading

Possibly related PRs

• [WEB-2443] fix: project member validation #5601: Role validation logic modifications in AccountTypeColumn
• [WEB-2467] fix: platform bug #5621: Enhancing user role management flexibility
• [WEB-1412]fix: split labels in kanban board #6253: Improving Kanban board label handling
• [WEB-2711]fix: guest mentions and assignees #6315: Restricting guest user assignments and mentions

Suggested labels

🧹chore, 🌐frontend

Suggested reviewers

• sriramveeraghanta
• SatishGandham
• rahulramesha

Poem

🐰 A dropdown's dance, members in line,
Flexible props, code so divine!
IDs flow free, errors now clear,
A rabbit's touch brings coding cheer!
Refactoring magic, smooth and bright 🌟

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 906d095 and 76b9afe.

📒 Files selected for processing (4)

• web/core/components/dropdowns/member/index.tsx (3 hunks)
• web/core/components/dropdowns/member/member-options.tsx (3 hunks)
• web/core/components/project/member-list-item.tsx (2 hunks)
• web/core/components/project/settings/member-columns.tsx (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (2)

• GitHub Check: lint-web
• GitHub Check: Analyze (javascript)

🔇 Additional comments (6)

web/core/components/project/member-list-item.tsx (2)

43-43: LGTM: Router navigation after successful project leave

The router navigation is correctly placed after the successful project leave operation.

---

53-54: Improved error messages for better user experience

The error messages are now more descriptive and user-friendly, clearly indicating what action cannot be performed.

Also applies to: 61-62

web/core/components/dropdowns/member/index.tsx (1)

27-27: LGTM: Clean implementation of new memberIds prop

The new optional memberIds prop is well-implemented:

• Properly typed as optional string array
• Correctly destructured from props
• Appropriately passed to child component

Also applies to: 56-56, 174-174

web/core/components/dropdowns/member/member-options.tsx (2)

23-23: LGTM: Consistent prop implementation

The memberIds prop is consistently implemented with the parent component, and the destructuring with alias prevents naming conflicts.

Also applies to: 33-33

---

71-71: Verify the impact of memberIds prioritization

The new logic prioritizes passed memberIds over project and workspace member IDs. While this provides more flexibility, we should ensure this doesn't affect existing functionality.

✅ Verification successful

Member IDs prioritization is safe and maintains compatibility

The changes maintain backward compatibility while adding flexibility through proper fallback chain (props → project → workspace). Existing usages passing workspace members as optional props remain unaffected.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Search for existing usages of MemberOptions to verify impact
ast-grep --pattern 'MemberOptions {
  $$$
}'

# Search for direct references to getProjectMemberIds and workspaceMemberIds
rg "getProjectMemberIds|workspaceMemberIds" -A 2

Length of output: 7382

web/core/components/project/settings/member-columns.tsx (1)

157-158: LGTM: Consistent error message improvement

The error message update maintains consistency with other similar messages across the application, providing clear feedback about the failed action.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.