Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: language support phase 2 #6323

Merged
merged 3 commits into from
Jan 6, 2025
Merged

Conversation

prateekshourya29
Copy link
Member

@prateekshourya29 prateekshourya29 commented Jan 6, 2025

Description

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Improvement (change that would cause existing functionality to not work as expected)
  • Code refactoring
  • Performance improvements
  • Documentation update

Screenshots and Media (if applicable)

Test Scenarios

References

Summary by CodeRabbit

Release Notes

  • New Features

    • Added platform OS detection hook to identify user's device and operating system
    • Introduced new sidebar menu components for improved navigation
  • Internationalization

    • Added "Inbox" translation for English, Spanish, French, and Japanese languages
  • Constants

    • Added new event constant for sidebar interactions
    • Introduced user permission and role enumerations
  • Refactor

    • Simplified sidebar menu rendering and management
    • Removed legacy dashboard-related constants and helpers

Copy link
Contributor

coderabbitai bot commented Jan 6, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

This pull request introduces significant changes to the sidebar navigation system in the web application. The modifications include removing existing dashboard-related constants, types, and helpers, and introducing new components for user and workspace sidebar menus. The changes streamline the sidebar navigation by creating more modular and focused components like SidebarUserMenuItem, SidebarWorkspaceMenuItem, and SidebarWorkspaceMenuHeader. Additionally, the PR adds new constants for user roles and platform detection, and updates internationalization files with new translations.

Changes

File Change Summary
packages/constants/src/event.ts Added SIDEBAR_CLICKED constant
packages/constants/src/index.ts Added export for event module
packages/constants/src/user.ts Added new enums: EUserPermissionsLevel, EUserWorkspaceRoles, EUserProjectRoles
packages/hooks/src/use-platform-os.tsx Added new usePlatformOS hook for platform detection
packages/i18n/src/locales/**/translations.json Added new "inbox" translations in multiple languages
web/core/components/workspace/sidebar/* Added new sidebar-related components and refactored existing ones
Deleted files Removed dashboard-related constants, types, and helpers in web/ce and web/ee

Sequence Diagram

sequenceDiagram
    participant User
    participant Sidebar
    participant PlatformDetector
    participant PermissionsManager
    participant TranslationService

    User->>Sidebar: Interact with sidebar
    Sidebar->>PlatformDetector: Detect platform
    PlatformDetector-->>Sidebar: Return platform info
    Sidebar->>PermissionsManager: Check user permissions
    PermissionsManager-->>Sidebar: Return permission status
    Sidebar->>TranslationService: Get localized labels
    TranslationService-->>Sidebar: Return translated text
    Sidebar->>User: Render menu items
Loading

Possibly related PRs

Suggested labels

🌟improvement, 🛠️refactor, 🌐frontend

Suggested reviewers

  • sriramveeraghanta
  • SatishGandham
  • pushya22

Poem

🐰 Sidebar dance, a rabbit's delight,
Components refactored, code shining bright
Menus now sleek, permissions so clear
Navigation's magic is finally here!
Hop, hop, hooray for clean design! 🎉


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 732963b and 25f7780.

📒 Files selected for processing (21)
  • packages/constants/src/event.ts (1 hunks)
  • packages/constants/src/index.ts (1 hunks)
  • packages/constants/src/user.ts (1 hunks)
  • packages/hooks/src/index.ts (1 hunks)
  • packages/hooks/src/use-platform-os.tsx (1 hunks)
  • packages/i18n/src/locales/en/translations.json (1 hunks)
  • packages/i18n/src/locales/es/translations.json (1 hunks)
  • packages/i18n/src/locales/fr/translations.json (1 hunks)
  • packages/i18n/src/locales/ja/translations.json (1 hunks)
  • web/ce/constants/dashboard.ts (0 hunks)
  • web/ce/helpers/dashboard.helper.ts (0 hunks)
  • web/ce/types/dashboard.ts (0 hunks)
  • web/core/components/workspace/sidebar/index.ts (1 hunks)
  • web/core/components/workspace/sidebar/user-menu-item.tsx (1 hunks)
  • web/core/components/workspace/sidebar/user-menu.tsx (2 hunks)
  • web/core/components/workspace/sidebar/workspace-menu-header.tsx (1 hunks)
  • web/core/components/workspace/sidebar/workspace-menu-item.tsx (1 hunks)
  • web/core/components/workspace/sidebar/workspace-menu.tsx (2 hunks)
  • web/ee/constants/dashboard.ts (0 hunks)
  • web/ee/helpers/dashboard.helper.ts (0 hunks)
  • web/ee/types/dashboard.ts (0 hunks)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@sriramveeraghanta sriramveeraghanta merged commit a6216be into preview Jan 6, 2025
9 of 11 checks passed
@sriramveeraghanta sriramveeraghanta deleted the language-support-phase-2 branch January 6, 2025 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants