-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WEB-3035] chore: add labels to treemap chart #6313
Conversation
WalkthroughThis pull request introduces an optional Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
web/core/components/core/charts/tree-map/map-content.tsx (1)
117-117
: Space before label could be refined
Using a leading space for the label is functional but consider whether a different separator (e.g., colon or newline) might be more appropriate in certain contexts.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
packages/types/src/charts.d.ts
(1 hunks)web/core/components/core/charts/tree-map/map-content.tsx
(2 hunks)
🔇 Additional comments (3)
packages/types/src/charts.d.ts (1)
38-38
: Optional label property is a simple yet effective enhancement
Adding an optionallabel
property is a clean change that extends flexibility in tree map item definitions without breaking existing functionality.web/core/components/core/charts/tree-map/map-content.tsx (2)
34-34
: Destructuring the newlabel
prop is well-aligned with the type update
This maintains consistency between your props and the updatedlabel
field inTreeMapItem
.
113-113
: New tracking style improves visual readability
Usingtracking-wider
on the text can enhance legibility, but please confirm it fits your overall design style.
Description
Type of Change
Summary by CodeRabbit
New Features
label
property to tree map itemsStyle
font-light
andtracking-wider
classes