[PE-88] fix: remove emoji edit for uneditable pages

[aaryan610]

Description

The emoji of uneditable pages(locked, archived, etc.) can no longer be edited now.

Type of Change

• Bug fix (non-breaking change which fixes an issue)

Summary by CodeRabbit

• Refactor
  • Simplified page header component's permission handling
  • Removed custom permission checks
  • Now using isContentEditable property to determine emoji icon picker's disabled state

[coderabbitai]

Walkthrough

The pull request modifies the PageDetailsHeader component in header.tsx, simplifying the permission handling logic. Instead of using separate variables for user permissions (allowPermissions, isAdmin, isOwner), the component now relies directly on the isContentEditable property from the page object to determine the disabled state of the EmojiIconPicker. This change streamlines the component's logic by removing explicit permission checks.

Changes

File	Change Summary
web/app/[workspaceSlug]/(projects)/projects/(detail)/[projectId]/pages/(detail)/header.tsx	- Removed useUserPermissions hook import - Eliminated allowPermissions, isAdmin, isOwner variables - Replaced isEditable with isContentEditable for EmojiIconPicker disabled state

Possibly related PRs

• [WEB-2443] fix: page permission validation #5589: Added user permission logic to header.tsx
• [WEB-2678]feat: added functionality to add labels directly from dropdown #6211: Removed allowPermissions variable from root.tsx
• fix: pages empty state authorization #6141: Modified access permissions in empty-state.ts
• [PE-98] fix: page title fixed height #6242: Changes to editor-body.tsx and title.tsx files

Suggested reviewers

• SatishGandham
• rahulramesha
• pushya22

Poem

🐰 Permissions dance away,
Simplicity takes the stage today,
One line replaces many a check,
isContentEditable saves the trek!
Code hops lighter, clean and bright 🌟

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

web/app/[workspaceSlug]/(projects)/projects/(detail)/[projectId]/pages/(detail)/header.tsx (1)

146-146: Using disabled={!isContentEditable} to respect uneditable state
Switching to isContentEditable for controlling the EmojiIconPicker’s disabled state simplifies permission handling. This matches the PR objective of disallowing edits on locked or archived pages. Consider adding a tooltip or explanatory message for a clearer user experience when the picker is disabled.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6a13a64 and 73515de.

📒 Files selected for processing (1)

• web/app/[workspaceSlug]/(projects)/projects/(detail)/[projectId]/pages/(detail)/header.tsx (3 hunks)

🔇 Additional comments (2)

web/app/[workspaceSlug]/(projects)/projects/(detail)/[projectId]/pages/(detail)/header.tsx (2)

18-18: Clean import statement aligns with updated permission logic
No issues found in removing the old permission hook references. This import precisely brings in the required hooks.

---

35-35: Destructuring isContentEditable from page
Accessing isContentEditable here centralizes the edit-state logic within the page object, improving maintainability. Ensure the page object is always defined to avoid null pointer issues.