Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove unwanted states fetching logic to avoid multiple API calls. #6158

Merged
merged 2 commits into from
Dec 5, 2024

Conversation

prateekshourya29
Copy link
Member

@prateekshourya29 prateekshourya29 commented Dec 5, 2024

Summary by CodeRabbit

  • New Features

    • The dropdown now fetches project states only through user interactions, enhancing control over when data is loaded.
  • Bug Fixes

    • Removed automatic fetching of project states, preventing unintended data loads when the project ID changes.

Copy link
Contributor

coderabbitai bot commented Dec 5, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

The changes involve modifications to the StateDropdown component in web/core/components/dropdowns/state.tsx. The useEffect hook, which previously triggered the onOpen function based on the projectId, has been removed. This change means that project states are no longer automatically fetched when the projectId changes; instead, the onOpen function is now called only through user interactions with the dropdown. The import statement for useEffect has also been eliminated, but the overall structure and core functionality of the dropdown remain unchanged.

Changes

File Change Summary
web/core/components/dropdowns/state.tsx Removed useEffect hook that triggered onOpen based on projectId. Eliminated useEffect import.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Dropdown
    participant StateFetcher

    User->>Dropdown: Click to open
    Dropdown->>StateFetcher: Fetch project states
    StateFetcher-->>Dropdown: Return project states
    Dropdown-->>User: Display states
Loading

🐰 "In the dropdown, a change took place,
No more auto-fetching, just user embrace.
Click to reveal the states with glee,
A hop and a skip, as happy as can be!
With each interaction, the states will show,
A new way to fetch, now off we go!" 🐇


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between cba68e2 and 0043f40.

📒 Files selected for processing (1)
  • web/core/components/dropdowns/state.tsx (1 hunks)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@SatishGandham SatishGandham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other drop-downs also need similar fixes.

@pushya22 pushya22 merged commit d55ee6d into preview Dec 5, 2024
9 of 12 checks passed
@pushya22 pushya22 deleted the fix/states-fetching branch December 5, 2024 09:56
sriramveeraghanta added a commit that referenced this pull request Dec 16, 2024
* modifed action and install.sh for selfhost

* updated selfhost readme and install.sh

* fixes

* changes suggested by code-rabbit

* chore: updated powered by (#6160)

* improvement: update fetch map during workspace-level module fetch to reduce redundant API calls (#6159)

* fix: remove unwanted states fetching logic to avoid multiple API calls. (#6158)

* chore remove unnecessary CTA (#6161)

* fix: build branch workflow upload artifacts

* fixes

* changes suggested by code-rabbit

* modifed action and install.sh for selfhost

* updated selfhost readme and install.sh

* fix: build branch workflow upload artifacts

* fixes

* changes suggested by code-rabbit

---------

Co-authored-by: guru_sainath <[email protected]>
Co-authored-by: Prateek Shourya <[email protected]>
Co-authored-by: rahulramesha <[email protected]>
Co-authored-by: sriram veeraghanta <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants