Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WEB-2802]fix: dorpdown visibility issue in safari #6151

Merged
merged 4 commits into from
Dec 4, 2024

Conversation

mathalav55
Copy link
Collaborator

@mathalav55 mathalav55 commented Dec 4, 2024

Summary

Fixed visibility issue of dropdown in intake for Safari browser.

Reference

WEB-2802

Summary by CodeRabbit

  • Bug Fixes

    • Improved compatibility of the CustomMenu component with Safari by adding a new stacking context.
  • Documentation

    • Added comments to clarify the purpose of the recent changes for better understanding.

@mathalav55 mathalav55 added 🐛bug Something isn't working 🌐frontend labels Dec 4, 2024
@mathalav55 mathalav55 added this to the v0.24.1 milestone Dec 4, 2024
@mathalav55 mathalav55 self-assigned this Dec 4, 2024
Copy link
Contributor

coderabbitai bot commented Dec 4, 2024

Walkthrough

The changes in this pull request focus on the CustomMenu component located in packages/ui/src/dropdowns/custom-menu.tsx. The main modification is the addition of the translate-y-0 class to the Menu.Items component, aimed at establishing a new stacking context for Safari browsers. The overall functionality and structure of the component remain unchanged, including its props and methods, as well as the dropdown interaction logic.

Changes

File Path Change Summary
packages/ui/src/dropdowns/custom-menu.tsx Added translate-y-0 class to Menu.Items for Safari compatibility. No other changes made.

Possibly related PRs

  • [WEB-2802]fix:filters drop down fix safari #6133: The changes in this PR also involve adding the translate-y-0 class to a dropdown component for Safari compatibility, directly relating to the modifications made in the main PR's CustomMenu component.

Suggested reviewers

  • rahulramesha
  • SatishGandham

🐰 In the dropdowns, where we play,
A class was added, hip-hip-hooray!
For Safari's quirks, it takes its stand,
CustomMenu now, perfectly planned!
With no other changes, it still holds tight,
A seamless experience, a joyful sight! 🌟


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 1b92a18 and f6bb217.

📒 Files selected for processing (1)
  • packages/ui/src/dropdowns/custom-menu.tsx (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • packages/ui/src/dropdowns/custom-menu.tsx

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@pushya22 pushya22 merged commit d537e56 into preview Dec 4, 2024
11 of 14 checks passed
@pushya22 pushya22 deleted the fix-intake_filters_dropdown_safari branch December 4, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛bug Something isn't working 🌐frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants