Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add back issue identifier for relation activity. #6106

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

prateekshourya29
Copy link
Member

@prateekshourya29 prateekshourya29 commented Nov 27, 2024

Summary by CodeRabbit

  • New Features

    • Enhanced display logic for issue activity values, showing either the new or old value based on the state of the activity.
  • Bug Fixes

    • Improved clarity in activity representation by ensuring that empty values are handled appropriately.

Copy link
Contributor

coderabbitai bot commented Nov 27, 2024

Walkthrough

The changes introduce conditional rendering logic within the IssueRelationActivity component in the relation.tsx file. A new condition checks if activity.old_value is an empty string, determining whether to display activity.new_value or activity.old_value. This modification affects how activity values are rendered in the IssueActivityBlockComponent.

Changes

File Change Summary
web/core/components/issues/issue-detail/issue-activity/activity/actions/relation.tsx Added conditional rendering logic to display activity.new_value if activity.old_value is empty; otherwise, it displays activity.old_value.

Possibly related PRs

Suggested labels

🐛bug, 🌐frontend

Poem

In the world of issues, a change so bright,
Old values hidden, new ones in sight.
A span to show what’s fresh and new,
A little logic, a clearer view!
Hooray for rendering, let’s all cheer,
For every activity, let’s make it clear! 🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Outside diff range and nitpick comments (1)
web/core/components/issues/issue-detail/issue-activity/activity/actions/relation.tsx (1)

33-33: Consider removing hardcoded trailing period

The hardcoded trailing period might cause double punctuation if the values already include periods. Consider handling punctuation in a more flexible way or as part of the activity content.

-        <span className="font-medium text-custom-text-100">{activity.new_value}.</span>
+        <span className="font-medium text-custom-text-100">{activity.new_value}</span>
-        <span className="font-medium text-custom-text-100">{activity.old_value}.</span>
+        <span className="font-medium text-custom-text-100">{activity.old_value}</span>

Also applies to: 35-35

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 1420b7e and 5770fb5.

📒 Files selected for processing (1)
  • web/core/components/issues/issue-detail/issue-activity/activity/actions/relation.tsx (1 hunks)

@pushya22 pushya22 merged commit e3799c8 into preview Nov 28, 2024
14 of 15 checks passed
@sriramveeraghanta sriramveeraghanta deleted the fix/issue-relation-acitivity branch November 28, 2024 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants