fix: live base server url.

[prateekshourya29]

Summary by CodeRabbit

• Bug Fixes

  • Improved URL handling by trimming whitespace from the LIVE_SERVER_BASE_URL, enhancing reliability.
  • Added error logging for better visibility of issues during URL construction.

• New Features

  • No new features introduced in this release, but existing functionality for collaborative and read-only editing remains intact.

[coderabbitai]

Walkthrough

The changes in this pull request modify the PageEditorBody component to enhance the handling of the LIVE_SERVER_BASE_URL variable by trimming whitespace. Additionally, error handling for the realtimeConfig now logs errors to the console during URL construction. The component's overall functionality and structure, including the rendering logic based on the isContentEditable flag, remain unchanged.

Changes

File	Change Summary
web/core/components/pages/editor/editor-body.tsx	Modified LIVE_SERVER_BASE_URL to trim whitespace; adjusted WS_LIVE_URL construction to use trimmed base URL; added console error logging for URL construction.

Possibly related PRs

• [WEB-2559] fix: web socket protocol. #5731: The changes in this PR also involve modifications to the realtimeConfig and the construction of the WS_LIVE_URL, which directly relates to the adjustments made in the main PR regarding the WebSocket URL and the LIVE_SERVER_BASE_URL.

Suggested reviewers

• SatishGandham
• sriramveeraghanta

Poem

In the editor's realm, so bright and fair,
A trim for the URL, with utmost care.
Errors now logged, a watchful eye,
Collaboration blooms, as we reach for the sky!
Hops of delight in the code we share,
A rabbit's cheer for the changes we dare! 🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 303901c and 1b306e6.

📒 Files selected for processing (1)

• web/core/components/pages/editor/editor-body.tsx (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• web/core/components/pages/editor/editor-body.tsx

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)

web/core/components/pages/editor/editor-body.tsx (1)

118-118: Approve changes with a minor suggestion for error handling

The changes to the LIVE_SERVER_BASE_URL construction are good. Using trim() prevents issues with malformed URLs due to whitespace, and the fallback to window.location.origin provides a safety net.

Consider enhancing the error handling to provide more context:

    } catch (error) {
-     console.error("Error creating realtime config", error);
+     console.error("Error creating realtime config:", error.message);
+     // Optionally, you could log this error to an error tracking service
      return undefined;
    }

This will give more specific information about what went wrong, which could be helpful for debugging.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 62c45f3 and 303901c.

📒 Files selected for processing (1)

• web/core/components/pages/editor/editor-body.tsx (1 hunks)