[WEB-2330] fix: you don't have permission toast on on bulk delete

[sharma01ketan]

[WEB-2330]

Changes:

• Bulk delete error modal is now visible only when non admins press delete/backspace in an open project.

• Previously it was visible for all users on all routes, except when admin were in an open project.

• For non admin, toast appears when a project is open.

• For admin, modal appears when a project is open.

Summary by CodeRabbit

• New Features

  • Improved security for project deletion via keyboard shortcuts by adding permission checks.

• Bug Fixes

  • Enhanced control flow to prevent unauthorized deletion actions in the Command Palette.

[coderabbitai]

Walkthrough

The changes in this pull request modify the CommandPalette component to enhance the handling of keyboard shortcuts for project deletion. The logic is updated to include a conditional check that verifies whether the user has the necessary permissions and a valid project context before executing the deletion action. This ensures that project deletions can only occur if the user meets the required administrative capabilities and a project is selected, thereby improving access control and user experience within the application.

Changes

Files	Change Summary
web/core/components/command-palette/command-palette.tsx	Updated logic to conditionally allow project deletion based on user permissions (canPerformProjectAdminActions) and the presence of a valid projectId.

Possibly related PRs

• [WEB-2419] chore: add toast alerts post access change of a page #5569: This PR introduces toast alerts for user actions, which is relevant as the main PR also modifies toast notifications related to permission checks in the performProjectBulkDeleteActions function.
• [WEB-2443] fix: project intake edit permission #5588: This PR focuses on enhancing user permissions, which aligns with the main PR's changes that improve permission checks for project deletion actions.
• [WEB-2443] fix: not authorized flicker #5593: This PR addresses user experience improvements related to authorization feedback, which connects to the main PR's focus on enhancing control flow and user feedback during deletion actions.

Poem

In the palette where commands play,
A rabbit hops, brightening the day.
With checks in place, no harm can be done,
Permissions guard each project, one by one.
So leap with joy, for the code is tight,
No more rogue deletions in the night! 🐇✨

Tip

OpenAI O1 model for chat

• We have deployed OpenAI's latest O1 model for chat.
• OpenAI claims that this model has superior reasoning capabilities than their GPT-4o model.
• Please share any feedback with us in the discussions post.

---

Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between dbf013e and c6bd1eb.

Files selected for processing (1)

• web/core/components/command-palette/command-palette.tsx (1 hunks)

Files skipped from review as they are similar to previous changes (1)

• web/core/components/command-palette/command-palette.tsx

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.