Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WEB-1256] fix: accept image as a valid comment #4409

Merged
merged 2 commits into from
May 9, 2024

Conversation

aaryan610
Copy link
Collaborator

Problem:

  1. Uploading only an image as a comment is not supported.

Solution:

  1. Updated the sanitize method to very strictly accept img tags.

Media:

Before After
Screen.Recording.2024-05-08.at.19.26.12.mov
Screen.Recording.2024-05-08.at.19.24.32.mov

Plane issue: WEB-1256

@aaryan610 aaryan610 added this to the v0.20-dev milestone May 8, 2024
@aaryan610 aaryan610 requested a review from SatishGandham May 8, 2024 13:57
@SatishGandham SatishGandham merged commit 3a66986 into preview May 9, 2024
11 of 12 checks passed
@SatishGandham SatishGandham deleted the fix/comment-create branch May 9, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants