Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WEB-1207] chore: avoid trimming of editor content #4396

Merged
merged 1 commit into from
May 8, 2024

Conversation

aaryan610
Copy link
Collaborator

@aaryan610 aaryan610 commented May 7, 2024

Problem:

  1. All the editors trim the editor content by removing the empty <p></p> tags from either ends, thus while writing the issue description, if the user intentionally adds some line breaks and the debounce kicks in between the typing, it removes those line breaks.

Solution:

  1. Removed the hardcoded trimming logic from the editor core, if needed trimming can be implemented wherever required using the exported getTrimmedHTML() helper function from the editor core.

Media:

Before After
Screen.Recording.2024-05-08.at.00.00.52.mov
Screen.Recording.2024-05-07.at.23.59.49.mov

Plane issue: WEB-1207

Copy link
Collaborator

@Palanikannan1437 Palanikannan1437 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🙌

@sriramveeraghanta sriramveeraghanta merged commit 32e601a into preview May 8, 2024
11 of 12 checks passed
@sriramveeraghanta sriramveeraghanta deleted the fix/description-trim branch May 8, 2024 10:12
@sriramveeraghanta sriramveeraghanta added this to the v0.20-dev milestone May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants