[WEB-1176] chore: filter dropdown indicator and code refactor #4379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anmolsinghbhatia
requested review from
SatishGandham,
sriramveeraghanta,
gurusainath and
rahulramesha
SatishGandham
requested changes
May 7, 2024
| @@ -61,6 +62,13 @@ export const ArchivedCyclesHeader: FC = observer(() => { | |||
| } | |||
| }; | |||
|
|
|||
| const appliedFilters: TCycleFilters = {}; | |||
There was a problem hiding this comment.
Since we are not using applied filters for display purposes and only dependent on the boolean value, can you bailout early as soon as you come across a filter.
const hasFilters = objectHasValues(currentProjectArchivedFilters ?? {})
// Put this in a utilities file
objectHasValues = (obj)=>{
// run the for loop here.
}
web/helpers/filter.helper.ts
Outdated
| @@ -26,6 +27,24 @@ export const calculateTotalFilters = (filters: TFilters): number => | |||
| .reduce((curr, prev) => curr + prev, 0) | |||
| : 0; | |||
|
|
|||
| /** | |||
There was a problem hiding this comment.
We can use the existing function above using typescript generics. Please create an issue for that and we will track it as a separate change.
SatishGandham
approved these changes
May 7, 2024
SatishGandham
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
This PR includes following changes:
Issue link: [WEB-1176]
Media: