Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WEB-1007] chore: invalid issue error empty state added #4372

Merged
merged 1 commit into from
May 6, 2024

Conversation

anmolsinghbhatia
Copy link
Collaborator

@anmolsinghbhatia anmolsinghbhatia commented May 6, 2024

Changes:

This PR resolves the issue with invalid issue ID causing an indefinite loading screen and instead renders the proper error page.

Issue link: [WEB-1007]

Media:

Before After
before after

description="The issue you are looking for does not exist or has been deleted."
primaryButton={{
text: "View other issues",
onClick: () => router.push(`/${workspaceSlug}/projects/${projectId}/issues`),

Check warning

Code scanning / CodeQL

Client-side URL redirect Medium

Untrusted URL redirection depends on a
user-provided value
.
@anmolsinghbhatia anmolsinghbhatia marked this pull request as ready for review May 6, 2024 08:17
@SatishGandham SatishGandham merged commit 562e508 into preview May 6, 2024
11 of 12 checks passed
@SatishGandham SatishGandham deleted the chore/invalid-issue-error-handling branch May 6, 2024 09:58
@sriramveeraghanta sriramveeraghanta added this to the v0.20-dev milestone May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants