Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WEB-1154] fix: delete attachment modal logic #4338

Merged
merged 3 commits into from
May 2, 2024

Conversation

aaryan610
Copy link
Collaborator

@aaryan610 aaryan610 commented May 2, 2024

Problem:

  1. Trying to delete an attachment is not possible, the delete attachment modal only deletes the last attachment on the list.

Solution:

  1. MobX store value to toggle the delete attachment modal was common for all the attachments, resulting in a conflict in the delete modals. Resolved the issue by using attachmentId to validate if the delete modal should be opened or not.

Plane issue: WEB-1154

@aaryan610 aaryan610 added 🐛bug Something isn't working 🌐frontend labels May 2, 2024
@aaryan610 aaryan610 added this to the v0.19-dev milestone May 2, 2024
@aaryan610 aaryan610 changed the title [WEB-] fix: delete attachment modal logic [WEB-1154] fix: delete attachment modal logic May 2, 2024
@sriramveeraghanta sriramveeraghanta merged commit 42c4c46 into preview May 2, 2024
11 of 12 checks passed
@sriramveeraghanta sriramveeraghanta deleted the fix/delete-attachment branch May 2, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛bug Something isn't working 🌐frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants