Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WEB-756] chore: spreadsheet layout cycle and module feature toggle validation #4121

Merged
merged 2 commits into from
Apr 4, 2024
Merged

[WEB-756] chore: spreadsheet layout cycle and module feature toggle validation #4121

merged 2 commits into from
Apr 4, 2024

Conversation

anmolsinghbhatia
Copy link
Collaborator

@anmolsinghbhatia anmolsinghbhatia commented Apr 4, 2024 •
edited
Loading

Problem:

  • Despite disabling cycles and modules from project settings, they remain accessible in spreadsheet layout and project analytics.

Solution:

  • Implemented validation to ensure that when cycles and modules are disabled.

Issue link: [WEB-756]

@anmolsinghbhatia anmolsinghbhatia added this to the v0.18.0-dev milestone Apr 4, 2024
@anmolsinghbhatia anmolsinghbhatia self-assigned this Apr 4, 2024
@anmolsinghbhatia anmolsinghbhatia marked this pull request as ready for review April 4, 2024 09:26
@rahulramesha rahulramesha merged commit b4cc58d into develop Apr 4, 2024
11 of 12 checks passed
@rahulramesha rahulramesha deleted the chore/module-and-cycle-feature-improvement branch April 4, 2024 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rahulramesha rahulramesha rahulramesha approved these changes

@sriramveeraghanta sriramveeraghanta Awaiting requested review from sriramveeraghanta

@gurusainath gurusainath Awaiting requested review from gurusainath

Assignees

@anmolsinghbhatia anmolsinghbhatia

Labels
🌐frontend 🌟improvement
Projects
None yet
Milestone
v0.18.0-dev
Development

Successfully merging this pull request may close these issues.
2 participants
@anmolsinghbhatia @rahulramesha