Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WEB-493] chore: custom search select input key down improvement #3787

Merged

Conversation

anmolsinghbhatia
Copy link
Collaborator

@anmolsinghbhatia anmolsinghbhatia commented Feb 25, 2024

Problem:

  1. Within the peek overview, when opening any search select dropdown and typing into the search input, pressing the escape key closes the peek overview instead of clearing the typed input.

Solution:

  1. Address this by implementing an input keydown handler that clears the typed input in the dropdown search, ensuring expected behavior.

Issue link: [WEB-493]

@anmolsinghbhatia anmolsinghbhatia added this to the v0.16 milestone Feb 25, 2024
@anmolsinghbhatia anmolsinghbhatia marked this pull request as ready for review February 25, 2024 04:22
@pushya22 pushya22 marked this pull request as draft February 25, 2024 10:22
@anmolsinghbhatia anmolsinghbhatia marked this pull request as ready for review February 26, 2024 12:59
@sriramveeraghanta sriramveeraghanta merged commit 67fdafb into develop Feb 26, 2024
7 of 9 checks passed
@sriramveeraghanta sriramveeraghanta deleted the chore/custom-search-select-dropdown-improvement branch February 26, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants